Update Cobra to v1.1.1 #2237
Update Cobra to v1.1.1 #2237
Conversation
There was a problem hiding this comment.
Nice catch! I'm happy to see completion script issues addressed.
The upgrade looks good, but I'm worried about the sudden proliferation of so many extra dependencies listed in our go.sum file. Let's spend some time looking over them (i.e. where do they come from?) before we merge this!
|
@mislav that is a good point. I did some investigating and all the additions stem from the upgrade of The upgrade also has patch updates to |
There was a problem hiding this comment.
It turns out that Viper is only used in spf13/cobra/cmd, which we don't use, but Viper and its sub-dependencies will still be listed in our go.sum even though it's technically not our runtime dependency. 😕
I guess this added bloat to go.sum is fine for now, but let's explore venues of migrating off of Cobra in the future.
Update
spf13/cobrato v1.1.1Cobra diff
Biggest cobra change since v1.0.0 is a reworking of all shell completion generation which should address a number of our issues.
closes #1775
closes #671
cc #1703
cc #716
cc #695