Fix continue browser for branch slash names #2249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #2243
Details
If you try to
Continue in browserusing the commandgh pr createand your branch's name is likebranch/#123, is opened a bad url in browser mixing the path with query params liketitleand displaying an unexpected prompt message.Example:
https://github.com/ephelsa/SOME-REPO/compare/master...branch/?title=branch%2F%23123#123?expand=1Prompt message:
Opening github.com/ephelsa/SOME-REPO/compare/master...branch/ in your browser.After the solution:
https://github.com/ephelsa/SOME-REPO/compare/master...branch%2F%23123?expand=1&title=branch%2F%23123Prompt message:
Opening github.com/ephelsa/SOME-REPO/compare/master...branch/#123 in your browser.