Print friendly error when "gh repo clone" is missing required argument #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e5141b to
af1d8a6
Compare
shrihankp
approved these changes
Oct 22, 2020
pkg/cmd/repo/clone/clone.go
Outdated
| Use: "clone <repository> [<directory>] [-- <gitflags>...]", | ||
| Args: func(cmd *cobra.Command, args []string) error { | ||
| if len(args) == 0 { | ||
| return &cmdutil.FlagError{Err: errors.New("cannot clone: no repository name given")} |
There was a problem hiding this comment.
@mislav Any suggestions on the copy?
There was a problem hiding this comment.
Hi there! Maybe will use var like this
var (
NoRepositoryNameErr = errors.New("cannot clone: no repository name given")
)
...
return &cmdutil.FlagError{Err: NoRepositoryNameErr}
and use this var here
https://github.com/cli/cli/pull/2253/files#diff-04c817e85387cae5077e022373e3a27f375cac7d29ed6abbe331337433442fd5R216
emhagman
commented
Oct 22, 2020
pkg/cmd/repo/clone/clone.go
Outdated
| Use: "clone <repository> [<directory>] [-- <gitflags>...]", | ||
| Args: func(cmd *cobra.Command, args []string) error { | ||
| if len(args) == 0 { | ||
| return &cmdutil.FlagError{Err: errors.New("cannot clone: no repository name given")} |
There was a problem hiding this comment.
@mislav Any suggestions on the copy?
shrihankp
approved these changes
Oct 23, 2020
mislav
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
@emhagman Thank you for your contribution! I've pushed a change that changes the error message to say "repository argument" instead of "repository name", since the argument is typically the repository OWNER/NAME pair, or even a full URL.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2216