Improve error message for "gh release create" command #2351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alissonbrunosa
commented
Nov 3, 2020
Comment on lines
+80
to
+86
| Args: func(cmd *cobra.Command, args []string) error { | ||
| if len(args) > 0 { | ||
| return nil | ||
| } | ||
|
|
||
| return &cmdutil.FlagError{Err: errors.New("could not create: no tag name provided")} | ||
| }, |
There was a problem hiding this comment.
It seems we have a couple of those custom messages already. Should we create something like:
func MinimumArgs(n int, msg string) cobra.PositionalArgs {
if msg == "" {
return cobra.MinimumNArgs(1)
}
return func(cmd *Command, args []string) error {
if len(args) < n {
return &cmdutil.FlagError{Err: errors.New(msg)}
}
return nil
}
}and we could use like:
Args: cmdutil.MinimumArgs(1, "could not create: no tag name provided")There was a problem hiding this comment.
That's a good idea; happy for that to be a follow-up, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It makes the error message for the
gh release createcommand clearer when a tag name is not passed inIt fixes #2327