Thanks to visit codestin.com
Credit goes to github.com

Add issue comment viewing #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mislav merged 6 commits into trunk from view-comments

Dec 15, 2020

Contributor

samcoe commented Nov 23, 2020 •

edited

Loading

This PR implements the ability to view issue comments in gh issue view. The PR is not actually as long as the line count suggests, it is mostly due to test fixtures. I left major design decisions/comments inline with the code.

Example TTY Output

Example Non-TTY Output

samcoe self-assigned this

samcoe force-pushed the view-comments branch from 8ac11a7 to 2da8973 Compare

November 24, 2020 08:20

samcoe commented

View reviewed changes

api/reaction_groups.go Show resolved Hide resolved

samcoe commented

View reviewed changes

pkg/cmd/issue/view/fixtures/issueView_previewWithEmptyBody.json Show resolved Hide resolved

samcoe commented

View reviewed changes

pkg/cmd/issue/view/view.go Outdated Show resolved Hide resolved

samcoe commented

View reviewed changes

pkg/cmd/issue/view/view.go Outdated Show resolved Hide resolved

samcoe commented

View reviewed changes

pkg/cmd/issue/view/view.go Show resolved Hide resolved

samcoe commented

View reviewed changes

pkg/cmd/issue/view/view.go Show resolved Hide resolved

samcoe commented

View reviewed changes

pkg/cmd/issue/view/view.go Outdated Show resolved Hide resolved

samcoe commented

View reviewed changes

utils/utils.go Show resolved Hide resolved

samcoe marked this pull request as ready for review

November 24, 2020 08:55

samcoe mentioned this pull request

Create issue comments #2535

Merged

mislav suggested changes

View reviewed changes

Contributor

mislav left a comment

Awesome work here, @samcoe!

api/queries_issue.go Outdated Show resolved Hide resolved

api/reaction_groups.go Outdated Show resolved Hide resolved

pkg/cmd/issue/view/fixtures/issueView_preview.json Show resolved Hide resolved

pkg/cmd/issue/view/view.go Outdated Show resolved Hide resolved

pkg/cmd/issue/view/view.go Show resolved Hide resolved

pkg/cmd/issue/view/view.go Show resolved Hide resolved

pkg/cmd/issue/view/view.go Outdated Show resolved Hide resolved

pkg/cmd/issue/view/view.go Outdated Show resolved Hide resolved

utils/utils.go Show resolved Hide resolved

samcoe added 3 commits

December 7, 2020 14:25


          Add issue comment viewing

c843a4f


          Appease the linter

8c5e5a3


          Update non-tty comment output

bad5a59

samcoe force-pushed the view-comments branch 3 times, most recently from da7dc59 to e3ad1e3 Compare

December 8, 2020 14:46


          Address PR comments

bec5e0c

samcoe force-pushed the view-comments branch from e3ad1e3 to bec5e0c Compare

December 8, 2020 15:24

mislav approved these changes

View reviewed changes

Contributor

mislav left a comment

This looks great! Thank you for the hard work ✨

pkg/cmd/issue/shared/lookup.go Outdated Show resolved Hide resolved

samcoe mentioned this pull request

Add ability to view comments with pr view #2575

Merged


          Reverse order of issue lookup checks

b2edf78

mislav reviewed

View reviewed changes

pkg/cmd/issue/view/view.go Outdated Show resolved Hide resolved


          Use spinner helper

efc05de

mislav merged commit 1e4fa60 into trunk

mislav deleted the view-comments branch

December 15, 2020 15:22

mislav restored the view-comments branch

December 15, 2020 15:24

mislav deleted the view-comments branch

December 15, 2020 15:31

ucul21 commented Jan 19, 2021

keep calm

mislav mentioned this pull request

gh issue view : different output when redirecting to a file #3239

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet