Thanks to visit codestin.com
Credit goes to github.com

Skip to content

- removed pr.Mergeable check to resolve issue #2544 #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

- removed pr.Mergeable check to resolve issue #2544 #2583

wants to merge 1 commit into from

Conversation

@ahmedadan
Copy link
Contributor

@ahmedadan ahmedadan commented Dec 9, 2020 •
edited
Loading

Looking to close Issue #2544 with the correction suggested by @mislav

  • all tests continue to pass

@ahmedadan ahmedadan changed the title - removed pr.Mergeable check to resolve issue #2544 as per mislav - removed pr.Mergeable check to resolve issue #2544 Dec 9, 2020
@ahmedadan ahmedadan marked this pull request as ready for review December 9, 2020 04:57
mislav
mislav approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good.

Tests still passing probably just means that there was no specific test for the UNKNOWN case.

@mislav
Copy link
Contributor

mislav commented Dec 9, 2020

Sorry— it appears that there is an identical submission as your PR done a few hours earlier: #2582

For duplicate PRs of equal quality, we tend to prioritize accepting ones that were submitted earlier.

Closing as duplicate of #2582

@mislav mislav closed this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mislav mislav mislav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahmedadan @mislav