Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add arm build for raspberry pi #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 15, 2020
Merged

add arm build for raspberry pi #2621

merged 3 commits into from
Dec 15, 2020

Conversation

@vilmibm
Copy link
Contributor

@vilmibm vilmibm commented Dec 14, 2020 •
edited
Loading

Adds arm to our arch list; this makes it easier to use gh on a raspberry pi.

Fixes #1960

@vilmibm vilmibm requested a review from a team December 15, 2020 01:56
mislav
mislav approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mislav
Copy link
Contributor

mislav commented Dec 15, 2020

These filenames get created:

  • gh_1.4.0-pre.1_linux_armv6.deb
  • gh_1.4.0-pre.1_linux_armv6.rpm
  • gh_1.4.0-pre.1_linux_armv6.tar.gz

Our current goreleaser naming scheme (probably yanked from their docs) appends the GOARM version v6. I think this distinction is useful if we ever ship GOARM=7 binaries in the future. @vilmibm does this sound okay?

@vilmibm
Copy link
Contributor Author

vilmibm commented Dec 15, 2020

i am fine with that, distinguishing from arm 7 in the future makes sense to me

@vilmibm vilmibm merged commit 04e6446 into trunk Dec 15, 2020
@mislav mislav deleted the arm32 branch December 16, 2020 12:37
Fear85
Fear85 reviewed Jan 1, 2021
View reviewed changes
Copy link

@Fear85 Fear85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read

@mislav mislav mentioned this pull request Aug 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Fear85 Fear85 Fear85 left review comments

@mislav mislav mislav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Raspbian Support

3 participants

@vilmibm @mislav @Fear85