Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle case when a cross-repo PR was already merged #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

Handle case when a cross-repo PR was already merged #2798

merged 1 commit into from
Jan 21, 2021

Conversation

@mislav
Copy link
Contributor

@mislav mislav commented Jan 18, 2021

In this case, do not ever offer to delete the branch.

Followup to #2789

@mislav
pr merge: handle case when a cross-repo PR was already merged
6e5a908 
In this case, do not ever offer to delete the branch.
samcoe
samcoe approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@mislav mislav merged commit ad62d6a into trunk Jan 21, 2021
@mislav mislav deleted the pr-merge-crossrepo branch January 21, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@samcoe samcoe samcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mislav @samcoe