Add range iterators for Go 1.23 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diacritics are curious when using words.SplitFunc
Top-level methods like words.Split are clean, but would preclude the use of Filter and Transform. I haven't figured out a clever to support them with Iter. Too bad. So just offer Iter for now, purely additive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Iter()method toSegmenterandScanner, for use withrange: https://go.dev/doc/go1.23#language—
New methodswords.Split([]byte)andwords.Scan(io.Reader)for use withrange.Originally, I’d hoped to add top-level APIs, such as
words.Split. Fewer dots! But this would preclude the use ofFilterandTransform. I haven’t figured out a way to support them with such an API, so just addingIter()is safe. Perhaps I will think of something.