Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Add clojure-ts-mode support#215

Closed
Andre0991 wants to merge 2 commits intoclojure-emacs:masterfrom
Andre0991:support-clojure-ts-mode
Closed

Add clojure-ts-mode support#215
Andre0991 wants to merge 2 commits intoclojure-emacs:masterfrom
Andre0991:support-clojure-ts-mode

Conversation

@Andre0991
Copy link

@Andre0991 Andre0991 commented Nov 20, 2023 •
edited
Loading

Add support to clojure-ts-mode 0.

  • Whenever the code used to reference clojure-mode, I changed it to be aware of clojure-ts-mode as well.
  • I've tested this branch for a few hours and everything seems working fine. However, I can keep testing it for more time, no rush to merge this. Also, note that I don't use the completions features.
  • checkdoc has a few warnings that already existed before this PR.
  • I used byte-compile-file and got no errors or warnings.

Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

@Andre0991 Andre0991 force-pushed the support-clojure-ts-mode branch 3 times, most recently from 0463f1f to 12e9c9d Compare November 20, 2023 19:03
@Andre0991
Add clojure-ts-mode support
7d91b92 
Add support to `clojure-ts-mode`, a Clojure major mode that uses
tree-sitter. For more details on `clojure-ts-mode`, consult its
repository [0].

[0]: https://github.com/clojure-emacs/clojure-ts-mode.
@Andre0991 Andre0991 force-pushed the support-clojure-ts-mode branch from 12e9c9d to 7d91b92 Compare November 20, 2023 19:13
@Andre0991 Andre0991 marked this pull request as ready for review November 20, 2023 19:14
bbatsov
bbatsov reviewed Nov 28, 2023
View reviewed changes
@bbatsov
Copy link
Member

bbatsov commented Nov 28, 2023

I think it may be prudent to allow the user to specify which mode they prefer if both are present, as the REPL font-locking is also hardcoded to clojure-mode right now.

@bbatsov
Copy link
Member

bbatsov commented Nov 28, 2023

You might also want to check for inspiration a similar PR for CIDER clojure-emacs/cider#3461

@Andre0991
Copy link
Author

Andre0991 commented Dec 2, 2023

 > I think it may be prudent to allow the user to specify which mode they prefer if both are present, as the REPL font-locking is also hardcoded to clojure-mode right now.

Hi Batsov.
Just to make sure I understand your suggestion, it is about choosing which functions to depending on whether the buffer uses clojure-mode or clojure-ts-mode, right?

For example, if the buffer uses clojure-ts-mode, then inf-clojure should use clojure-ts-find-ns rather than clojure-find-ns. This holds for all clojure-mode functions used by inf-clojure.

Makes sense?

@bbatsov
Copy link
Member

bbatsov commented Dec 14, 2023

If all of the functions exist in clojure-ts-mode - sure. I'm guessing in some cases something might not exist in clojure-ts-mode yet, so you'll have to stick to the clojure-mode function in that case. I was thinking of some defcustom like inf-clojure-preferred-clojure-mode that controls which mode to use internally that can do so inference by default. (e.g. prefer clojure-ts-mode if present)

I hope this makes sense.

@Andre0991
Copy link
Author

Andre0991 commented Dec 14, 2023

Cool, I'll implement it.

@bbatsov
Copy link
Member

bbatsov commented Feb 11, 2024

@Andre0991 Any updates?

@rrudakov rrudakov mentioned this pull request May 24, 2025
Merged
4 tasks
@bbatsov
Copy link
Member

bbatsov commented May 24, 2025

Closing in favor of #217

@bbatsov bbatsov closed this May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbatsov bbatsov bbatsov left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Andre0991 @bbatsov