Update to stacks. Add import to all configs. Remove hardcoded settings. Add Terraform S3 backend generation
#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import to all configs. Remove hardcoded settings. Add Terraform S3 backend generationstacks. Add import to all configs. Remove hardcoded settings. Add Terraform S3 backend generation
osterman
approved these changes
Nov 19, 2020
osterman
reviewed
Nov 19, 2020
Comment on lines
+1
to
+11
| namespace: eg | ||
|
|
||
| terraform_backend_environment: ue2 | ||
|
|
||
| terraform_backend_stage: root | ||
|
|
||
| terraform_backend_role_environment: gbl | ||
|
|
||
| terraform_backend_role_stage: root | ||
|
|
||
| kubeconfig_profile_environment: gbl |
There was a problem hiding this comment.
Suggested change
| namespace: eg | |
| terraform_backend_environment: ue2 | |
| terraform_backend_stage: root | |
| terraform_backend_role_environment: gbl | |
| terraform_backend_role_stage: root | |
| kubeconfig_profile_environment: gbl | |
| components: | |
| globals: | |
| namespace: eg | |
| terraform_backend_environment: ue2 | |
| terraform_backend_stage: root | |
| terraform_backend_role_environment: gbl | |
| terraform_backend_role_stage: root | |
| kubeconfig_profile_environment: gbl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
stacks(instead ofenvironment/stage)components(instead ofprojects)importto all configswhy
stacksinstead ofenvironment/stageto define configurations - this will allow arbitrary naming the stacks and not tying them to env/stage, as well as separation of stacks for the same environment/stage into different files (e.g. terraform config in one file, helmfiles config in another), or separation of stacks by AWS resourcesimportto YAML stack configs - allow automatically importing global-globals and stack-globals into each configuration