Update CLI for Terraform state backend #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
approved these changes
Nov 19, 2020
|
This looks excellent! =) |
osterman
reviewed
Nov 19, 2020
| @@ -0,0 +1,61 @@ | |||
| type: s3 | |||
There was a problem hiding this comment.
Hrmm... type at the top-level sounds too generic.
What if we had:
terraform:
remote_backend: s3
backend:
s3:
There was a problem hiding this comment.
will improve that in the next PR
osterman
added a commit
that referenced
this pull request
Nov 4, 2025
This implements the auth.defaults configuration for deterministic identity selection, solving the CI "multiple defaults" problem. **New PRD: Auth Default Settings (auth-default-settings.md)** Schema Addition: - auth.defaults.identity (string) - Selected default identity - auth.defaults.session (SessionConfig) - Global session defaults - auth.defaults.console (ConsoleConfig) - Global console defaults - auth.defaults.keyring (KeyringConfig) - Global keyring defaults Identity Selection Precedence: 1. --identity=explicit (CLI flag) 2. ATMOS_IDENTITY (env var) 3. auth.defaults.identity (selected default) ← NEW 4. identity.default: true (favorites) 5. Error: no default identity Key Concepts: - auth.defaults.identity = "Selected default" (single, deterministic) - identity.default: true = "Favorites" (multiple, interactive) - Profiles use auth.defaults.identity for deterministic behavior - Base config can use favorites without breaking CI **Updates to Atmos Profiles PRD:** Dependencies Section: - Added reference to Auth Default Settings PRD - Added challenge #7: Identity selection in CI CI Profile Example: - Updated to use auth.defaults.identity - Fixed Gomplate syntax: {{ env "GITHUB_RUN_ID" }} - Added session duration defaults - Documented precedence chain and CI behavior Developer Profile Example: - Shows combined pattern: auth.defaults.identity + identity.default: true - Demonstrates selected default + favorites for quick switching - Added multiple identities (sandbox + prod) - Documented usage patterns and benefits Integration Section: - Added "Integration with Auth Default Settings" section - Problem/solution comparison (with/without auth.defaults) - Three usage patterns: CI, Developer, Base Config - Precedence with profiles active - Key benefits for profiles Technical Dependencies: - Added auth-default-settings.md as explicit dependency **Why This Design:** Problem: Multiple identity.default: true causes errors in CI (no TTY) Solution: auth.defaults.identity provides deterministic selection Benefit: Profiles can encapsulate auth config for specific environments Use Cases: - CI profiles: Set auth.defaults.identity for non-interactive - Developer profiles: Combine selected default + favorites - Base config: Use favorites only (forces profile/explicit selection in CI) Implementation: Both PRDs will be implemented together as they are tightly coupled - profiles need auth.defaults for CI use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
variantfiles into YAML configurationterraform-backend.variantcompletely generic - it will work with any backends (e.g.s3,remote) and is completely configuration driven