Update helmfile CLI #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuru
approved these changes
Nov 30, 2020
osterman
added a commit
that referenced
this pull request
Nov 5, 2025
- Added *Provided boolean fields to EditorConfigOptions for tracking CLI flags - Updated EditorConfigParser to set Provided fields using flag.Changed - Fixed initializeConfig to respect CLI > config precedence for boolean flags - Prevents config from overriding explicitly provided false CLI flags Before: --dry-run=false with config dry_run=true → result was true (WRONG) After: --dry-run=false with config dry_run=true → result is false (CORRECT) Addresses code review item #9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
kubeconfig-profile-patterntohelm-aws-profile-patternhelm-aws-profile-patternto select an AWS profile for helmfile commandswhy
helm-aws-profile-patternis used not only for kubeconfig, but also for helm and helmfilehelm-aws-profile-patternwhen calling the helmfile CLI (still having the option to specify a different AWS profile)