chore(volo-http): do not put meta config in service #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Millione
previously approved these changes
Aug 9, 2024
Putting request related config in `MetaServiceConfig` will be difficult to maintain, so in this commit we put them in context and when client creates a request, it will clone the config into context. In addition, use `Option<Duration>` for timeout interfaces is unnecessary, but it will introduce many breaking changes. This commit also revert those changes. Signed-off-by: Yu Li <[email protected]>
7791e95 to
89e6ec1
Compare
Option<Duration> for timeout interfaces
PureWhiteWu
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Putting request related config in
MetaServiceConfigwill be difficult to maintain.In addition, use
Option<Duration>for timeout interfaces is unnecessary, but it will introduce many breaking changes.Solution
Move
timeoutandfail_on_error_statusfromMetaServiceConfiginto context and when client creates a request, it will clone the config into context.Revert changes for timeout related interfaces.