Log step name, instead of stack fqn #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Gonna merge this since we already agreed this is the right thing to do, and it's a 1 line change (aside from updating the tests). |
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
Log step name, instead of stack fqn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought up in #551 (comment), this changes how steps are logged, so that we log the short "step name" instead of the full stack name. The reasoning for this is that, with multi-account/region support now in, it's entirely possible to have multiple stacks with the same name in a single config (e.g. multiple
vpc's in different regions). This also sorta sets the stage for supporting other types of steps in the graph, that aren't CloudFormation stacks (e.g. hooks, targets, etc).In verbose mode, you're still able to correlate a node in the graph, with the resulting CloudFormation stack name: