Fix an issue introduced in #594 #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
594 assumed that `dump` would use `False` as it's default, but since `--dump` is a `str` type, it instead uses `None` when it is not specified on the CLI. The truth is that this is more pythonic anyway, and has the same effect. I can't imagine when this could cause un-expected behaivior.
Member
Author
|
@zaro0508 can you verify this is ok for what you were thinking? Note: This was hard to detect. Integration tests in my environment worked. Why? Because I don't delete my s3 bucket between runs, so even though |
russellballestrini
approved these changes
May 14, 2018
ejholmes
reviewed
Jun 21, 2018
| """ | ||
| return outline is False and dump is False | ||
| print "OUTLINE: %s, DUMP: %s" % (outline, dump) |
Contributor
There was a problem hiding this comment.
Was this intended to be left in? Was totally confused why my logs started showing this.
Member
Author
There was a problem hiding this comment.
Almost definitely not. I can pull it.
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
594 assumed that `dump` would use `False` as it's default, but since `--dump` is a `str` type, it instead uses `None` when it is not specified on the CLI. The truth is that this is more pythonic anyway, and has the same effect. I can't imagine when this could cause un-expected behaivior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
594 assumed that
dumpwould useFalseas it's default, but since--dumpis astrtype, it instead usesNonewhen it is notspecified on the CLI.
The truth is that this is more pythonic anyway, and has the same effect.
I can't imagine when this could cause un-expected behaivior.