Remove DescribeStacks call from prepare_stack_for_update #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@danielkza since you originally added |
phobologic
approved these changes
Feb 7, 2018
Member
phobologic
left a comment
There was a problem hiding this comment.
This LGTM - have you ran the integration tests? Probably worthwhile just in case.
| else: | ||
| return self.default_update_stack | ||
|
|
||
| def prepare_stack_for_update(self, fqn, tags): |
Member
There was a problem hiding this comment.
Need to update the docstring.
Contributor
Author
Yep, integration tests pass. |
7e6737b to
7657f7a
Compare
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
=========================================
- Coverage 88.63% 88.6% -0.03%
=========================================
Files 94 94
Lines 6000 5987 -13
=========================================
- Hits 5318 5305 -13
Misses 682 682
Continue to review full report at Codecov.
|
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
Remove DescribeStacks call from prepare_stack_for_update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small performance optimization to remove an unnecessary DescribeStacks call from the
prepare_stack_for_updatemethod.Before this change, the outbound network calls for a single noop stack update would look like this:
The 3rd DescribeStacks (step 4) is unnecessary, and can be easily removed, since we already have a DescribeStacks response from the first call.