Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@alecrajeev
Copy link
Contributor

Uses moto to mock creating and describing the keypair API for unit testing. This increases coverage for hooks/keypair

Copy link
Member

@phobologic phobologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@danielkza
Copy link
Contributor

This test has hardcoded paths to CircleCI that break running the tests locally: #709

Having written the hook and now looking at this, I strongly recommend to:

a) Not test the logging messages. That makes the test very fragile and adds little value against regressions.
b) Create a temporary directory and use it as the "home base" for any test that requires simulating/inspect file manipulation. It's the most comprehensive way to observe behavior close to reality, and does not break in different environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants