-
Couldn't load subscription status.
- Fork 2
feat: lanczos downscaling #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I will have to hardcore test this with my test images. Also how does Lanczos filtering work again? I need this code a little more commented. |
|
idk how to explain lanczos, my brain is fried. https://en.wikipedia.org/wiki/Lanczos_resampling |
|
Hope that comment explains it |
|
Can we name some variables better, like what is Also is roseate/src/image/fast_downsample.rs Lines 30 to 33 in c4b2359
|
|
Alright starting to understand this... EDIT: I'm commenting more of the code now. |
|
I don't know if it's gotten slower or what but image-rs down-sampling is faster with every other image except purposely large images like |
|
Imagine this on an AMD Threadripper 💀 you'll be able to downsample 8k images A LOT faster. BTW I do have a potential solution I could try to speed this up, i just don't know I'll work until I actually implement it and test it A LOT as we might be talking about very small milliseconds of improvement. |
update with upstream
…vement feat: reduce memory lock and predetermine lanczo kernel calculations
Image used: https://cdn.ananas.moe/lanczos_test.jpg