Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: zero copy to create a new Buffer #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 2 commits into from
Dec 6, 2025
Merged

fix: zero copy to create a new Buffer #916

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dfa6ea
fix: zero copy to create a new Buffer
fengmk2 Dec 6, 2025
8413c87
Apply suggestion from @Copilot
fengmk2 Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/repository/DistRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ export class DistRepository {
async readDistBytesToBuffer(dist: Dist): Promise<Buffer | undefined> {
const bytes = await this.readDistBytes(dist);
if (!bytes) return undefined;
return Buffer.isBuffer(bytes) ? bytes : Buffer.from(bytes);
// if bytes is Uint8Array, should use zero copy to create a new Buffer
// https://nodejs.org/docs/latest-v24.x/api/buffer.html#static-method-bufferfromarraybuffer-byteoffset-length
return Buffer.from(bytes.buffer, bytes.byteOffset, bytes.byteLength);
}
Comment on lines 90 to 96
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Check Node.js version configuration
echo "=== Checking Node.js version configuration ==="
if [ -f "package.json" ]; then
  echo "--- package.json engines ---"
  cat package.json | jq -r '.engines.node // "not specified"'
fi

if [ -f ".nvmrc" ]; then
  echo "--- .nvmrc ---"
  cat .nvmrc
fi

if [ -f ".node-version" ]; then
  echo "--- .node-version ---"
  cat .node-version
fi

Repository: cnpm/cnpmcore

Length of output: 170

🏁 Script executed:

#!/bin/bash

# Examine the DistRepository.ts file structure
echo "=== Examining DistRepository.ts ==="
wc -l app/repository/DistRepository.ts

echo -e "\n=== All method names in DistRepository ==="
ast-grep --pattern 'class $_ {
  $$$
  $_($$$) {
    $$$
  }
  $$$
}' app/repository/DistRepository.ts || grep -n "^\s*\(async\|public\|private\)\s\+\w\+" app/repository/DistRepository.ts

echo -e "\n=== Full DistRepository file (first 150 lines) ==="
head -150 app/repository/DistRepository.ts

Repository: cnpm/cnpmcore

Length of output: 170

Rename method to follow repository naming convention.

The method readDistBytesToBuffer violates the repository naming convention. Repository methods must use findX, saveX, removeX, or listXs patterns. Rename this to findDistBytesAsBuffer or appropriate equivalent.

The zero-copy Buffer implementation using Buffer.from(bytes.buffer, bytes.byteOffset, bytes.byteLength) is correct, but cannot be approved until the naming convention is addressed.

🤖 Prompt for AI Agents 
In app/repository/DistRepository.ts around lines 90 to 96, rename the method
readDistBytesToBuffer to follow repository naming conventions (use
findX/saveX/removeX/listXs); update the method name to findDistBytesAsBuffer (or
another find-prefixed variant), keep the same async signature
Promise<Buffer|undefined> and the existing zero-copy Buffer.from(...)
implementation, and then update all internal and external
references/imports/tests to use the new name so TypeScript types and exports
remain consistent.


async readDistBytesToJSONBuilder(dist: Dist): Promise<JSONBuilder | undefined> {
Expand Down
Loading