chore(benchmark): add CPU profiler analysis tools #917

fengmk2 · 2025-12-07T05:51:55Z

Add scripts and reports for analyzing V8/xprofiler CPU profiles:

analyze-profile.js: Comprehensive CPU profile analyzer
hotspot-finder.js: Find specific hotspots with filtering
call-tree-analyzer.js: Analyze call relationships between layers
flamegraph-convert.js: Convert to folded stack format for flame graphs
REPORT.md: Analysis findings showing Leoric Bone constructor as main hotspot
CALL-DIAGRAM.md: Visual call relationship diagram

Key findings: Leoric ORM Bone constructor consumes 15.38% of active CPU time, while application code only uses 2.18%.

🤖 Generated with Claude Code

Summary by CodeRabbit

Documentation
- Added comprehensive profiling documentation including CPU analysis reports, call flow diagrams, and performance bottleneck analysis.
Chores
- Introduced profiling analysis scripts and tools for CPU performance investigation.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Add scripts and reports for analyzing V8/xprofiler CPU profiles: - analyze-profile.js: Comprehensive CPU profile analyzer - hotspot-finder.js: Find specific hotspots with filtering - call-tree-analyzer.js: Analyze call relationships between layers - flamegraph-convert.js: Convert to folded stack format for flame graphs - REPORT.md: Analysis findings showing Leoric Bone constructor as main hotspot - CALL-DIAGRAM.md: Visual call relationship diagram Key findings: Leoric ORM Bone constructor consumes 15.38% of active CPU time, while application code only uses 2.18%. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

coderabbitai · 2025-12-07T05:52:01Z

Caution

Review failed

The pull request is closed.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Introduces a comprehensive profiling and analysis toolkit for the Leoric ORM, consisting of documentation files and five Node.js scripts that process CPU profiles to identify performance bottlenecks, map call relationships, convert to flame graph format, and generate detailed analysis reports.

Changes

Cohort / File(s)	Summary
Profiling Documentation `benchmark/profiler/CALL-DIAGRAM.md`, `benchmark/profiler/REPORT.md`, `benchmark/profiler/analysis-report.md`	Three Markdown reports documenting CPU profiling analysis, call flow diagrams, root cause analysis for Leoric Bone constructor hotspot, optimization recommendations, and detailed performance metrics breakdown.
Profile Analysis Tools `benchmark/profiler/analyze-profile.js`	Node.js script that parses V8 CPU profiles and generates comprehensive textual reports including time distribution, top functions/files by CPU time, category breakdown, hotspots, and entry point analysis.
Call Path Mapper `benchmark/profiler/call-tree-analyzer.js`	Node.js CLI tool that maps call relationships between application code and hotspot functions, groups paths by entry points, categorizes nodes (app/npm/node/native), and generates Mermaid flowchart diagrams.
Flame Graph Converter `benchmark/profiler/flamegraph-convert.js`	Node.js script that converts xprofiler/V8 CPU profiles to Brendan Gregg's folded stack format for flame graph visualization.
Hotspot Finder `benchmark/profiler/hotspot-finder.js`	Node.js CLI tool that identifies CPU performance hotspots with detailed call paths, supports filtering and result limiting, and outputs human-readable hotspot reports with caller chains.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

call-tree-analyzer.js requires careful review of traversal logic, node categorization heuristics, and Mermaid diagram generation
analyze-profile.js and hotspot-finder.js contain moderate complexity in profile data transformation and filtering logic
Verification of edge case handling (missing data, native URLs, cycle protection) across all tools
Cross-validation of categorization logic consistency between tools (node/npm/app/native detection)

Poem

🐰 Hop along the call stack trees, profiling with such ease!
Flame graphs bloom and hotspots gleam, revealing bottleneck streams,
Bone constructor, now we see thee, through analysis so pretty!
With charts and maps and folded stacks, the rabbit runs analytics! 📊✨

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch cpu-profiler

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37d043c and 5f153ea.

📒 Files selected for processing (7)

benchmark/profiler/CALL-DIAGRAM.md (1 hunks)
benchmark/profiler/REPORT.md (1 hunks)
benchmark/profiler/analysis-report.md (1 hunks)
benchmark/profiler/analyze-profile.js (1 hunks)
benchmark/profiler/call-tree-analyzer.js (1 hunks)
benchmark/profiler/flamegraph-convert.js (1 hunks)
benchmark/profiler/hotspot-finder.js (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist · 2025-12-07T05:52:11Z

Summary of Changes

Hello @fengmk2, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances our performance analysis capabilities by introducing a suite of CPU profiling tools. These tools parse V8/xprofiler profiles to generate comprehensive reports and visual call diagrams, which have already been used to pinpoint the Leoric ORM Bone constructor as a major CPU hotspot. The aim is to provide actionable insights for optimizing application performance, particularly within third-party libraries, while confirming the efficiency of our core application logic.

Highlights

New Profiling Tools: Introduced analyze-profile.js, hotspot-finder.js, call-tree-analyzer.js, and flamegraph-convert.js for in-depth CPU profile analysis.
Performance Hotspot Identified: The Leoric ORM Bone constructor was found to consume 15.38% of active CPU time, making it the primary bottleneck.
Detailed Reports & Diagrams: Added REPORT.md and CALL-DIAGRAM.md to document analysis findings, including call flow diagrams and optimization recommendations.
Application Efficiency: Application code was observed to be highly efficient, accounting for only 2.18% of CPU time, shifting focus to third-party dependencies.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

benchmark/profiler/analyze-profile.js

benchmark/profiler/call-tree-analyzer.js

+
+// Find all target nodes (hotspots)
+const targetRegex = new RegExp(targetPattern, 'i');
+const callerRegex = new RegExp(callerPattern, 'i');


benchmark/profiler/call-tree-analyzer.js

gemini-code-assist

Code Review

This pull request introduces a valuable set of tools for CPU profile analysis, including several scripts for processing profile data and detailed reports summarizing the findings. The analysis and recommendations in the markdown reports are thorough and insightful. The scripts are generally well-written, but I've identified a few areas for improvement: a bug in argument handling in analyze-profile.js, and some unused code in call-tree-analyzer.js and hotspot-finder.js. Addressing these points will enhance the robustness and maintainability of these new tools.

benchmark/profiler/analyze-profile.js

gemini-code-assist · 2025-12-07T05:53:32Z

benchmark/profiler/call-tree-analyzer.js

+
+// Find all target nodes (hotspots)
+const targetRegex = new RegExp(targetPattern, 'i');
+const callerRegex = new RegExp(callerPattern, 'i');


The callerPattern variable is parsed from command-line arguments and used to initialize callerRegex, but callerRegex is never used anywhere in the script. This appears to be dead code and should be removed to improve clarity and maintainability. You might also want to remove the logic for parsing the --caller argument.

gemini-code-assist · 2025-12-07T05:53:32Z

benchmark/profiler/hotspot-finder.js

+// Calculate total time including children
+function calculateTotalTime(nodeId, visited = new Set()) {
+  if (visited.has(nodeId)) return 0;
+  visited.add(nodeId);
+
+  const node = nodeMap.get(nodeId);
+  if (!node) return 0;
+
+  let total = node.hitCount;
+  if (node.children) {
+    node.children.forEach(childId => {
+      total += calculateTotalTime(childId, visited);
+    });
+  }
+  return total;
+}


The function calculateTotalTime is defined but never called. This is dead code and should be removed to improve code clarity and maintainability.

codecov · 2025-12-07T05:54:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.25%. Comparing base (683ee1d) to head (5f153ea).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
- Coverage   95.37%   95.25%   -0.12%     
==========================================
  Files         197      197              
  Lines       22104    22104              
  Branches     2442     2049     -393     
==========================================
- Hits        21081    21056      -25     
- Misses       1023     1048      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

benchmark/profiler/analyze-profile.js

benchmark/profiler/call-tree-analyzer.js

+
+    // Show detailed path with better formatting
+    const detailedPath = data.examplePath;
+    let indent = '   ';


benchmark/profiler/call-tree-analyzer.js

+    let indent = '   ';
+
+    detailedPath.forEach((node, i) => {
+      let prefix = i === 0 ? '   ' : '   │';


Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: MK (fengmk2) <[email protected]>

benchmark/profiler/analyze-profile.js

+      url = 'node_modules/' + match[1];
+    }
+  } else if (url.includes('node:')) {
+    url = url;


[skip ci] ## 4.14.0 (2025-12-07) * feat: avoids Bone constructor overhead for each row (#919) ([f8eedd8](f8eedd8)), closes [#919](#919) [hi#level](https://github.com/hi/issues/level) * chore(benchmark): add CPU profiler analysis tools (#917) ([5ef2c67](5ef2c67)), closes [#917](#917)

github-actions · 2025-12-07T08:11:02Z

🎉 This PR is included in version 4.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-code-quality bot found potential problems Dec 7, 2025

View reviewed changes

gemini-code-assist bot reviewed Dec 7, 2025

View reviewed changes

fengmk2 added 2 commits December 7, 2025 14:19

FIXUP

520bf5e

FIXUP

e9dc9ad

fengmk2 changed the title ~~feat(benchmark): add CPU profiler analysis tools~~ chore(benchmark): add CPU profiler analysis tools Dec 7, 2025

github-code-quality bot found potential problems Dec 7, 2025

View reviewed changes

Apply suggestions from code review

5f153ea

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: MK (fengmk2) <[email protected]>

github-code-quality bot found potential problems Dec 7, 2025

View reviewed changes

benchmark/profiler/analyze-profile.js

url = 'node_modules/' + match[1];

}

} else if (url.includes('node:')) {

url = url;

fengmk2 marked this pull request as ready for review December 7, 2025 07:35

fengmk2 merged commit 5ef2c67 into master Dec 7, 2025
27 of 29 checks passed

fengmk2 deleted the cpu-profiler branch December 7, 2025 07:36

github-actions bot added the released label Dec 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(benchmark): add CPU profiler analysis tools #917

chore(benchmark): add CPU profiler analysis tools #917

Uh oh!

fengmk2 commented Dec 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 7, 2025 •

edited

Loading

Review failed

Other AI code review bot(s) detected

Uh oh!

gemini-code-assist bot commented Dec 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

gemini-code-assist bot Dec 7, 2025

Uh oh!

gemini-code-assist bot Dec 7, 2025

Uh oh!

codecov bot commented Dec 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chore(benchmark): add CPU profiler analysis tools #917

chore(benchmark): add CPU profiler analysis tools #917

Uh oh!

Conversation

fengmk2 commented Dec 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Other AI code review bot(s) detected

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

gemini-code-assist bot commented Dec 7, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fengmk2 commented Dec 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 7, 2025 •

edited

Loading

codecov bot commented Dec 7, 2025 •

edited

Loading