Implement EPICSNState Class #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelLyra8
commented
Dec 12, 2025
| ) | ||
|
|
||
| zoom = self.getObjectByRole("zoom") | ||
| calibration_x = zoom.getProperty("mm_per_pixel_x") |
Collaborator
Author
There was a problem hiding this comment.
Change to this file will cause a conflict with the bluesky branch
|
|
||
| def init(self): | ||
| super().init() | ||
| low_limit = self.get_property("low_limit", "") |
Collaborator
Author
There was a problem hiding this comment.
I think the limits should be in the EPICSActuator class. And if they are not set, the class should get the values directly from the PV.
| try: | ||
| with gevent.Timeout(timeout, exception=TimeoutError): | ||
| while ( | ||
| self.setpoint != EPICSActuator.get_value(self) and not self._wait_task.is_set() |
Collaborator
Author
There was a problem hiding this comment.
The EPICSActuator could be generalize to accept strings, and this wait_ready method could be removed.
| self._nominal_limits = limits | ||
| self.emit("limitsChanged", (self._nominal_limits,)) | ||
|
|
||
| def update_limits(self, limits=None): |
Collaborator
Author
There was a problem hiding this comment.
The name should be standardized with the one in EPICSMotor that is called get_limits. And maybe set in the EPICSActuator
| value = EPICSActuator.get_value(self) | ||
| return self.value_to_enum(value) | ||
|
|
||
| def set_limits(self, limits=(None, None)): |
Collaborator
Author
There was a problem hiding this comment.
I think this should be in the EPICSActuator
added 10 commits
December 18, 2025 17:06
Delete example xml file (which does not make sense here), fix the imports from other classes, adjust the zoom limits to what is currently being used in the beamline (1 to 8), and delete the get_value function which was poorly implemented, and already inherited from EPICSNState class
This is done in order to account for the value_to_enum, that needs to be called for the values of the Zoom object. Combined with a proper polling setting, this updates the frontend when a zoom value is altered from outside MXCuBE4
In the parent class, AbstractNState, the functions set_limits and update_limits raise a NotImplementedError. Because LNLSZoom is a class that is an N state but has limits, the limits must be set manually. This is why the limits are defined at init (and not at the configuration file) and also set with specific functions at the LNLSZoom class. There could be a way to set these limits in the configuration file, but I could not find that.
This can be done because all NState objetcs also use these funcions and because limits can be defined in configuration files
Default value is used if any of them was not defined. This is the case e.g. for all EPICSMotors, which inhetir from the EPICSActuator class.
1a488a5 to
cd3e785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the EPICSNState class in order to be able to use it with Enum values.