Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[#186] Support GHC-8.10 #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2020
Merged

[#186] Support GHC-8.10 #188

merged 3 commits into from
Apr 18, 2020

Conversation

@chshersh
Copy link
Contributor

Resolves #186

Supports GHC-8.10 in all packages except co-log-polysemy (currently blocked by dependency of polysemy).

@chshersh chshersh added the CI label Apr 18, 2020
@chshersh chshersh requested a review from vrom911 April 18, 2020 19:16
@chshersh chshersh self-assigned this Apr 18, 2020
hint-man[bot]
hint-man bot approved these changes Apr 18, 2020
View reviewed changes
Copy link

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

vrom911
vrom911 reviewed Apr 18, 2020
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
We can resolve co-log-polysemy 8.10 issue separately, and release these two packages.

chshersh and others added 2 commits April 18, 2020 20:28
vrom911
vrom911 approved these changes Apr 18, 2020
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! co-log-polysemy is ready for the release as well 👍

@vrom911 vrom911 merged commit 9227c7f into master Apr 18, 2020
@vrom911 vrom911 deleted the chshersh/186-Support-GHC-8.10 branch April 18, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrom911 vrom911 vrom911 approved these changes

+1 more reviewer

@hint-man hint-man[bot] hint-man[bot] approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chshersh chshersh

Labels

CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support GHC-8.10

3 participants

@chshersh @vrom911