Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@alaendle
Copy link
Member

@alaendle alaendle commented Jul 2, 2023

No description provided.

@alaendle alaendle requested a review from vrom911 as a code owner July 2, 2023 08:39
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I aagree, Maybe we should add the reason in comments or docs somewhere explaining what is the blocker for current Windows test build? Otherwise, I agree 👍🏼

@alaendle
Copy link
Member Author

alaendle commented Jul 3, 2023

@vrom911 to be honest I couldn't really tell what goes wrong on Windows - locally I recognize that qualified imports didn't seem to work in the tests.

src\Colog\Message.hs:422: failure in expression `showTime $ C.Time 1577656800000000000'
expected: "[29 Dec 2019 22:00:00.000 +00:00] "
 but got:
          ^
          <interactive>:27:12: error:
              Not in scope: data constructor `C.Time'
              NB: no module named `C' is imported.

But also after using full names in the test code it didn't worked; also I believe this might be triggered by some change in ghci, but I haven't found a corresponding issue on the GHC issue tracker. So I just added a generell comment why doctest is disabled on windows. However I believe this shouldn't be a problem, since I think we are good enough if all tests pass on linux systems 😉

@alaendle alaendle requested a review from vrom911 July 12, 2023 16:05
@alaendle alaendle merged commit 3815b87 into co-log:main Aug 28, 2023
@alaendle alaendle deleted the feature/update-ghcs branch August 28, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants