pgwire: return right-sized int and float types #37295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Opened lib/pq#857 - adding this to our vendored copy fixes all of the unit tests failures. |
|
This seems good to go -- all tests passing. But, I didn't fix the second point in #36811, about |
madelynnblue
approved these changes
May 6, 2019
andy-kimball
reviewed
May 6, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andy-kimball, @jordanlewis, and @knz)
pkg/sql/pgwire/types.go, line 91 at r1 (raw file):
// details: https://github.com/cockroachdb/cockroach/issues/36811 // // TODO(andyk): Remove this once issue #36811 is resolved.
I think you should leave this comment in until you get rid of the entire mapResultOid method.
With the upgraded type system, we're now in the position to return the right size of integers to clients that use the binary protocol. Do so. Release note (backwards-incompatible change): integer and float columns of less than the max width will now be returned as their own type via the binary protocol. For example, an int4 column will be returned in 32 bits over the pgwire binary protocol instead of 64 bits.
jordanlewis
commented
Jun 14, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/sql/pgwire/types.go, line 91 at r1 (raw file):
Previously, andy-kimball (Andy Kimball) wrote…
I think you should leave this comment in until you get rid of the entire
mapResultOidmethod.
Done.
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 14, 2019
37295: pgwire: return right-sized int and float types r=jordanlewis a=jordanlewis With the upgraded type system, we're now in the position to return the right size of integers to clients that use the binary protocol. Do so. Closes #36811. Release note (backwards-incompatible change): integer and float columns of less than the max width will now be returned as their own type via the binary protocol. For example, an int4 column will be returned in 32 bits over the pgwire binary protocol instead of 64 bits. Co-authored-by: Jordan Lewis <[email protected]>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Jun 18, 2019
38184: sql: fix scrub on tables with mixed case r=jordanlewis a=jordanlewis There was insufficient quoting in the generated queries to prevent issues with tables or columns with mixed case. This was causing issues with the random syntax generator, which tends to produce the query EXPERIMENTAL SCRUB DATABASE system, since the system database contains tables with columns with mixed case. Release note: None 38186: roachtest: update orm blacklists to remove some expected failures r=jordanlewis a=jordanlewis Upgraded support for int2 and int4 datatypes in #37295 caused us to pass some more tests. This PR updates the blacklists to remove their expected failures. Closes #37596. Closes #38179. 38210: changefeedccl: enable abort and split nemeses in TestNemeses r=tbg a=danhhz These deadlocked when the test was written but seems like they've been fixed sometime since. \o/ On a gceworker: 17846 runs so far, 0 failures, over 2h9m40s Release note: None Co-authored-by: Jordan Lewis <[email protected]> Co-authored-by: Daniel Harrison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upgraded type system, we're now in the position to return the
right size of integers to clients that use the binary protocol. Do so.
Closes #36811.
Release note (backwards-incompatible change): integer and float columns
of less than the max width will now be returned as their own type via
the binary protocol. For example, an int4 column will be returned in 32
bits over the pgwire binary protocol instead of 64 bits.