[SYMFONY] Add ability to configure slugify #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I don't think that is necessary. The Slugify bundle only contains three files, how I don't think we need to move them to separate namespaces. |
Contributor
Author
|
@florianeckerstorfer Alright, i will move them all into one. |
Contributor
Author
|
@florianeckerstorfer Actually it would be better to follow the symfony convention. The loader doesn't pick the config atm and the extension has been initialised in a wrong way.
I will adjust that now manually, but in future it would be better to stick to conventions. |
Contributor
Author
|
@florianeckerstorfer Seems all good now. Do you need me to squash commits or is all good? |
Member
|
Since these are a lot of commits, yes, please squash. |
[SYMFONY] Add ability to configure slugify [SYMFONY] Revert separation into DependencyInjection directory [SYMFONY] Fix wrongly initialised extension [SYMFONY] @Covers for CocurSlugifyExtensionTest::load [SYMFONY] Adjust CocurSlugifyBundleTest
Contributor
Author
|
@florianeckerstorfer done. |
Member
|
Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CocurSlugifyExtensioninto theDependencyInjectionfolder to comply with Symfony's bundle standard