focusableInThis: Return first focusable widget, not last #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WidgetBase.focusableInThis() says it "returns the first Focusable element within this widget". It calls WidgetWalkDown. WidgetWalkDown calls the given function and stops walking the current branch of the tree if the function returns false. But then it keeps going with other branches of the tree. Which means if there are multiple focusable child widgets, focusableInThis seems to return the last Focusable widget. Instead, abort the walk if the first focusable widget has been found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WidgetBase.focusableInThis() says it "returns the first Focusable element within this widget". It calls WidgetWalkDown.
WidgetWalkDown calls the given function and stops walking the current branch of the tree if the function returns false. But then it keeps going with other branches of the tree. Which means if there are multiple focusable child widgets, focusableInThis seems to return the last Focusable widget.
Instead, abort the walk if the first focusable widget has been found.
First reported in Slack.