gpudrawer and system.Drawer have SetClearColor #1280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lor to the color.Scheme.Background so resizing doesn't have bad-looking background. Fixes #1253
kkoreilly
requested changes
Nov 1, 2024
…round by default, every time, because it has no cost. also base gpu system uses this default because it makes more sense than Black as a default. removed SetClearColor from the system api.
kkoreilly
approved these changes
Nov 1, 2024
Member
kkoreilly
left a comment
There was a problem hiding this comment.
You can definitely see that the new approach is much better; any time you find yourself adding things for each platform separately, you should think about DRY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that sets the clear color to the color.Scheme.Background so resizing doesn't have bad-looking background. Fixes #1253