A set of stage / window sizing fixes #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ply when popup is a significant fraction of the size of the source window that it is a popup of. much better.
…idgets / dialogs to call it -- seems to cut off a bit of size on my mac but we should see how general that is. also system.Window.SetSize was not implemented on desktop! how is that possible?
Member
Author
|
@kkoreilly can you test resize to contents? |
…n be dealt with that way.
kkoreilly
requested changes
Nov 14, 2024
Member
kkoreilly
left a comment
There was a problem hiding this comment.
Definitely somewhat buggy for me. Also centralized docs would be nice...
kkoreilly
requested changes
Nov 14, 2024
kkoreilly
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the popup sizing and positioning logic from c881462 to only apply when popup is a significant fraction of the size of the source window that it is a popup of. much better.
add an option on Stage to disable min size of a new window, and also to specify the size of the window manually.
add a
ResizeToContentsfunction to Scene that resizes an existing Scene to fit current contents, and renameprefSize->contentSizefixes #1283 and fixes #1298