Use GitHub Artifacts to upload and download testdata images in CI #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge tests meaningful
…mage testdata handling approach
…g for update test images in imagex to ease doing so in CI workflow_dispatch
…rename CORE_UPDATE_TESTS to CORE_UPDATE_TESTDATA
…different artifact name to prevent the fail files from being download and propagated on future CI runs
…ngs in 'fail' search results in CI logs
…ure consistent results
…h offscreen as a multi-window platform
… multi-window offscreen paradigm
…correctly in Drawer.Start
…indow to prevent app from quitting since we never call core.Wait() on offscreen and thus we don't need it
Member
Author
|
This is all working now except for a number of random variations in rendering in several tests, resulting in CI failures. |
…renderContext itself so that other goroutines can update
kkoreilly
commented
Jan 27, 2025
Member
Author
kkoreilly
left a comment
There was a problem hiding this comment.
This all seems to be finally working!
rcoreilly
previously approved these changes
Jan 27, 2025
rcoreilly
approved these changes
Jan 27, 2025
Member
rcoreilly
left a comment
There was a problem hiding this comment.
Again, no annoying comments :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for our unit tests to actually compare current images to previous ones, ensuring proper regression testing; if the image result of any unit test changes, CI will fail and we will have to fix the issue or update the images using
-tags updateif it is intended. I added a manual button trigger for the workflow that enables-tags updateso we don't have to manually change the workflow back and forth every time there are changes to the images.This PR also makes offscreen a multi-window platform and merges AssertRender and AssertRenderScreen to fix testing unreliability for multi-scene tests.