Compute DPI as 160 * DPR * Scale instead of using Physical DPI #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r apps and the web; the previous behavior of having the physical size of widgets be the same on all platforms sounded great in theory but resulted in low quality font rendering and inconsistency with all other apps
…tem that does not guarantee constant physical size
rcoreilly
requested changes
Dec 12, 2024
Member
rcoreilly
left a comment
There was a problem hiding this comment.
This will not be merged without an option to use physical size.
rcoreilly
approved these changes
Dec 13, 2024
Member
rcoreilly
left a comment
There was a problem hiding this comment.
After further discussion, we can use the Physical DPI field to accomplish exact print-size rendering of things like print preview as needed in future apps, and the fact that this convention is used in all other apps makes sense for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
logical dpi = 160 * dpr * scale, as that is consistent with all other apps and the web. The previous behavior of having the physical size of widgets be the same on all platforms sounded great in theory but resulted in low quality font rendering and inconsistency with all other apps. This new paradigm looks completely correct on all of my monitors and VMs, whereas the old one required manually zooming in on VMs and low-DPI monitors.This PR also hides wgpu warnings since there are a lot of extraneous ones, and it updates our version of webgpu to include cogentcore/webgpu@ad7475f, which is a key fix for a
Cannot perform Construct on a detached ArrayBuffercrash on web. It also fixesGLFWCreateWindownot building on web.Fixes #1358 (the issue was the incorrect logical DPI computation for low-DPI monitors as discussed above)