Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix for #1387 -- layout logic says that bounding box should be based on Alloc, not Actual; also fix form stale closure issue using field path #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kkoreilly merged 16 commits into from
Dec 24, 2024
Merged

Fix for #1387 -- layout logic says that bounding box should be based on Alloc, not Actual; also fix form stale closure issue using field path #1389

kkoreilly merged 16 commits into from
Dec 24, 2024

Conversation

@rcoreilly
Copy link
Member

@rcoreilly rcoreilly commented Dec 21, 2024 •
edited by kkoreilly
Loading

Fixes #1387, fixes #1390

kkoreilly
kkoreilly reviewed Dec 22, 2024
View reviewed changes
@kkoreilly kkoreilly mentioned this pull request Dec 22, 2024
Closed
@rcoreilly rcoreilly marked this pull request as draft December 22, 2024 00:31
@rcoreilly
Copy link
Member Author

rcoreilly commented Dec 23, 2024

ps will rename Actual -> Need in a later PR to make it clearer what it "actually" is.

@kkoreilly kkoreilly mentioned this pull request Dec 23, 2024
Merged
@rcoreilly rcoreilly marked this pull request as ready for review December 23, 2024 23:07
@rcoreilly
Copy link
Member Author

rcoreilly commented Dec 24, 2024

ok now actually fully ready :)

kkoreilly
kkoreilly requested changes Dec 24, 2024
View reviewed changes
@kkoreilly kkoreilly changed the title Fix for #1387 -- layout logic says that bounding box should be based on Alloc, not Actual Fix for #1387 -- layout logic says that bounding box should be based on Alloc, not Actual; also fix form stale closure issue Dec 24, 2024
@kkoreilly kkoreilly changed the title Fix for #1387 -- layout logic says that bounding box should be based on Alloc, not Actual; also fix form stale closure issue Fix for #1387 -- layout logic says that bounding box should be based on Alloc, not Actual; also fix form stale closure issue using field path Dec 24, 2024
@kkoreilly kkoreilly merged commit 8b26e9d into main Dec 24, 2024
1 check passed
@kkoreilly kkoreilly deleted the form branch December 24, 2024 07:42
@kkoreilly kkoreilly mentioned this pull request Dec 24, 2024
Open
@rcoreilly rcoreilly mentioned this pull request Jan 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkoreilly kkoreilly kkoreilly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@rcoreilly @kkoreilly