-
-
Notifications
You must be signed in to change notification settings - Fork 0
Plot api updates and basic example #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… to multiple return values issue in yaegi
…what to run after doing go mod tidy to fix baremetal build
…gs to append -- if only Go were so smart :) baremetal is now robust to missing results.
|
@kkoreilly go ahead and merge! |
|
I confirmed that it works with the our readline, although we should definitely update to https://github.com/reeflective/readline at some point. |
kkoreilly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rcoreilly This looks good enough for now, as long as you can clearly articulate two things:
- What is the specific advantage of using gRPC here and all of the extra stuff associated with it instead of just using net/rpc?
- What is the difference between simmer and baremetal? Do those names accurately capture that distinction?
net/rpc is frozen and unsupported going forward, and only supports Go clients. Multiple sources warned against using it for new projects, in favor of gRPC which is actively maintained, automatically provides support for any language client, and has much better docs and examples etc.
from the (updated) READMEs:
|
|
Okay, the simmer and baremetal distinction makes sense. I am a little bit skeptical about using gRPC to have multi-language support, since that is not a use case we care about, and so we are generating all of these protobuf related files with a major footprint and a massive loss in idiomaticness compared to just transmitting simple https://pkg.go.dev/encoding/gob values that can use our enums and types directly. |
|
it is a small price to pay, and grpc handles all the protocol stuff from one .proto file, so it is conceptually simpler. someone someday (including me) may want to use baremetal via python or js or whatever -- it is a very nice minimal system for managing jobs on a bare metal machine. |
No description provided.