feat: adjust for tokenless v3 #434

joseph-sentry · 2024-05-06T16:57:03Z

we are no longer sending the X-Tokenless-PR header and we are changing the format of the contents of the X-Tokenless header

The X-Tokenless header will now be set to <fork user name>:<branch name> and will be the only extra header we send for tokenless requests. We get the value of this header from the TOKENLESS environment variable that will be set by the Codecov action.

github-actions · 2024-05-06T16:57:41Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T16:57:42Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T16:57:43Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T16:57:45Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

codecov · 2024-05-06T16:57:58Z

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2668 tests with 4 failed, 2664 passed and 0 skipped.

View the full list of failed tests

Test Description	Failure message
Testsuite: pytest Test name: api.temp.calculator.test_calculator::test_divide Envs: - python3.8	def test_divide(): > assert Calculator.divide(1, 2) == 0.5 E assert 1.0 == 0.5 E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2) E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide .../temp/calculator/test_calculator.py:30: AssertionError
Testsuite: pytest Test name: api.temp.calculator.test_calculator::test_divide Envs: - python3.9	def test_divide(): > assert Calculator.divide(1, 2) == 0.5 E assert 1.0 == 0.5 E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2) E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide .../temp/calculator/test_calculator.py:30: AssertionError
Testsuite: pytest Test name: api.temp.calculator.test_calculator::test_divide Envs: - python3.10	def test_divide(): > assert Calculator.divide(1, 2) == 0.5 E assert 1.0 == 0.5 E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2) E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide .../temp/calculator/test_calculator.py:30: AssertionError
Testsuite: pytest Test name: api.temp.calculator.test_calculator::test_divide Envs: - python3.11	def test_divide(): > assert Calculator.divide(1, 2) == 0.5 E assert 1.0 == 0.5 E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2) E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T17:23:52Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T17:23:53Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T17:23:54Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T17:23:58Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

thomasrockhu-codecov · 2024-05-07T09:40:26Z

codecov_cli/commands/report.py

 @click.option(
    "--code", help="The code of the report. If unsure, leave default", default="default"
 )
-@click.option(


this is a breaking change. I think that users that run the CLI in a workflow_dispatch need this

I just don't know if it makes sense for the create-report command

ahhh I see, that does make sense. however, we should probably for now make it a deprecated field

thomasrockhu-codecov · 2024-05-08T12:51:05Z

codecov_cli/helpers/request.py



+def get_auth_header(token):
+    tokenless = os.environ.get("TOKENLESS", None)


are we making this change for the orb and step too? Why doesn't the CLI just do this itself?

i don't think the CLI has access to the same context as the action but i can double check, but you are correct we should make a similar change the the orb and step as well

github-actions · 2024-05-08T13:58:57Z

❌ Failed Test Results:

Completed 667 tests with 1 failed, 666 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-08T13:58:58Z

❌ Failed Test Results:

Completed 667 tests with 1 failed, 666 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-08T13:58:59Z

❌ Failed Test Results:

Completed 667 tests with 1 failed, 666 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-08T13:59:03Z

❌ Failed Test Results:

Completed 667 tests with 1 failed, 666 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

codecov_cli/commands/report.py

thomasrockhu-codecov · 2024-05-09T12:45:00Z

codecov_cli/commands/report.py

-    help="Specify the pull request number mannually. Used to override pre-existing CI environment variables",
+    help="Deprecated option, this option has no effect on the execution of this command anymore. Specify the pull request number mannually. Used to override pre-existing CI environment variables",
    cls=CodecovOption,
    fallback_field=FallbackFieldEnum.pull_request_number,


perhaps we don't need this anymore either

github-actions · 2024-05-09T14:06:53Z

❌ Failed Test Results:

Completed 667 tests with 1 failed, 666 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-09T14:06:55Z

❌ Failed Test Results:

Completed 667 tests with 1 failed, 666 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-09T14:06:57Z

❌ Failed Test Results:

Completed 667 tests with 1 failed, 666 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-09T14:06:57Z

❌ Failed Test Results:

Completed 667 tests with 1 failed, 666 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

we are no longer sending the X-Tokenless-PR header and we are changing the format of the contents of the X-Tokenless header Signed-off-by: joseph-sentry <[email protected]>

Signed-off-by: joseph-sentry <[email protected]>

Co-authored-by: Tom Hu <[email protected]>

github-actions · 2024-05-09T15:25:01Z

❌ Failed Test Results:

Completed 667 tests with 1 failed, 666 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-09T15:25:04Z

❌ Failed Test Results:

Completed 667 tests with 1 failed, 666 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-09T15:25:05Z

❌ Failed Test Results:

Completed 667 tests with 1 failed, 666 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-09T15:25:07Z

❌ Failed Test Results:

Completed 667 tests with 1 failed, 666 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

matt-codecov · 2024-05-14T23:37:39Z

codecov_cli/services/commit/__init__.py

-    pull_dict = get_pull(service, decoded_slug, pr) if not token else None
-    if is_fork_pr(pull_dict):
-        headers = {"X-Tokenless": pull_dict["head"]["slug"], "X-Tokenless-PR": pr}
-        branch = pull_dict["head"]["slug"] + ":" + branch


don't we still need this?

joseph-sentry force-pushed the tokenless-v3 branch from 627866b to 653ef1c Compare May 6, 2024 17:23

thomasrockhu-codecov reviewed May 7, 2024

View reviewed changes

thomasrockhu-codecov reviewed May 8, 2024

View reviewed changes

joseph-sentry mentioned this pull request May 8, 2024

feat: add support for tokenless v3 codecov/codecov-action#1410

Merged

thomasrockhu-codecov reviewed May 9, 2024

View reviewed changes

joseph-sentry requested review from a team and removed request for a team May 9, 2024 15:24

joseph-sentry and others added 3 commits May 9, 2024 11:24

feat: adjust for tokenless v3

b6795fb

we are no longer sending the X-Tokenless-PR header and we are changing the format of the contents of the X-Tokenless header Signed-off-by: joseph-sentry <[email protected]>

fix: deprecate --pr instead of removing it

85c2a2a

Signed-off-by: joseph-sentry <[email protected]>

Update codecov_cli/commands/report.py

4fbd6ec

Co-authored-by: Tom Hu <[email protected]>

joseph-sentry force-pushed the tokenless-v3 branch from 4e8013d to 4fbd6ec Compare May 9, 2024 15:24

matt-codecov reviewed May 14, 2024

View reviewed changes

joseph-sentry closed this May 22, 2024



		def get_auth_header(token):
		tokenless = os.environ.get("TOKENLESS", None)

feat: adjust for tokenless v3 #434

feat: adjust for tokenless v3 #434

Uh oh!

Conversation

joseph-sentry commented May 6, 2024

Uh oh!

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

codecov bot commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

thomasrockhu-codecov May 7, 2024

Choose a reason for hiding this comment

Uh oh!

joseph-sentry May 7, 2024

Choose a reason for hiding this comment

Uh oh!

thomasrockhu-codecov May 8, 2024

Choose a reason for hiding this comment

Uh oh!

thomasrockhu-codecov May 8, 2024

Choose a reason for hiding this comment

Uh oh!

joseph-sentry May 8, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 8, 2024

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 8, 2024

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 8, 2024

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 8, 2024

❌ Failed Test Results:

Uh oh!

Uh oh!

thomasrockhu-codecov May 9, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 9, 2024

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 9, 2024

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 9, 2024

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 9, 2024

❌ Failed Test Results:

Uh oh!

github-actions bot commented May 9, 2024

❌ Failed Test Results:

Uh oh!

codecov bot commented May 6, 2024 •

edited

Loading