migrate jcifs classes to org.codelibs.jcifs.smb package #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the jcifs library from the legacy jcifs package to the new org.codelibs.jcifs.smb package structure. The migration includes updating all package references in documentation, build configuration, and removing obsolete interface files from the old package namespace.
Key changes:
- Update package imports in README.md examples from
jcifs.*toorg.codelibs.jcifs.smb.* - Migrate OSGi bundle configurations in pom.xml to use the new package structure
- Remove legacy interface files (ACE.java, BufferCache.java, Config.java) from the old package
Reviewed Changes
Copilot reviewed 67 out of 1706 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updates Java import statements in code examples to use new package structure |
| pom.xml | Updates OSGi bundle export/import configurations and file exclusions to new package paths |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ing little-endian encoding/decoding and offsets
…d-safe pipe ops, strict URL canonicalization, adaptive credit management, and stronger AES-256 defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request migrates the codebase from the legacy
jcifspackage to the neworg.codelibs.jcifs.smbpackage structure. The changes update package imports, OSGi bundle configurations, and code/documentation references throughout the project to reflect the new namespace. Additionally, obsolete interface files in the old package are removed.Migration to new package structure
README.mdand example code are updated fromjcifstoorg.codelibs.jcifs.smband its subpackages. [1] [2]pom.xmlare changed to use the neworg.codelibs.jcifs.smbpackage, including updates to class references and exclusions. [1] [2] [3]Removal of legacy interfaces
src/main/java/jcifs/ACE.java,src/main/java/jcifs/BufferCache.java, andsrc/main/java/jcifs/Config.javaare deleted from the codebase, removing references to the old package and legacy APIs. [1] [2] [3]