feat(config): Add preserveShareCase option for DFS case-sensitive namespaces #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…espaces Add configuration option to preserve share name case instead of converting to uppercase. This is required for DFS namespaces with case-sensitive link names. Changes: - Add isPreserveShareCase() to Configuration interface - Implement in BaseConfiguration, DelegatingConfiguration, PropertyConfiguration - Property: jcifs.smb.client.preserveShareCase (default: false) - Fix share comparison in SmbTreeConnection to use case-insensitive matching - Conditionally preserve case in SmbTreeImpl based on configuration 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds configuration support for preserving share name case, which is necessary for DFS namespaces with case-sensitive link names. By default, share names are converted to uppercase, but this new option allows preserving the original case when needed.
- Introduces
isPreserveShareCase()configuration method with default valuefalse - Updates share comparison logic to use case-insensitive matching
- Conditionally preserves share name case in
SmbTreeImplbased on configuration
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/org/codelibs/jcifs/smb/Configuration.java | Adds interface method for preserveShareCase configuration |
| src/main/java/org/codelibs/jcifs/smb/config/BaseConfiguration.java | Implements preserveShareCase field with default false |
| src/main/java/org/codelibs/jcifs/smb/config/DelegatingConfiguration.java | Delegates preserveShareCase to wrapped configuration |
| src/main/java/org/codelibs/jcifs/smb/config/PropertyConfiguration.java | Parses preserveShareCase from properties |
| src/main/java/org/codelibs/jcifs/smb/impl/SmbTreeImpl.java | Conditionally preserves share case based on configuration |
| src/main/java/org/codelibs/jcifs/smb/impl/SmbTreeConnection.java | Uses case-insensitive comparison for share matching |
| src/test/java/org/codelibs/jcifs/smb/config/BaseConfigurationTest.java | Tests default preserveShareCase value |
| src/test/java/org/codelibs/jcifs/smb/config/DelegatingConfigurationTest.java | Tests preserveShareCase delegation |
| src/test/java/org/codelibs/jcifs/smb/config/PropertyConfigurationTest.java | Tests preserveShareCase property parsing |
| src/test/java/org/codelibs/jcifs/smb/impl/SmbTreeImplTest.java | Tests share case preservation behavior |
| src/test/java/org/codelibs/jcifs/smb/impl/SmbTreeConnectionTest.java | Tests case-insensitive share comparison |
| src/test/java/org/codelibs/jcifs/smb/impl/NtlmAuthenticatorTest.java | Code formatting changes only |
| src/test/java/org/codelibs/jcifs/smb/impl/NtlmPasswordAuthenticatorTest.java | Code formatting changes only |
| src/test/java/org/codelibs/jcifs/smb/impl/NtlmNtHashAuthenticatorTest.java | Code formatting changes only |
| src/test/java/org/codelibs/jcifs/smb/internal/smb1/com/SmbComDeleteDirectoryTest.java | Code formatting changes only |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/test/java/org/codelibs/jcifs/smb/impl/NtlmPasswordAuthenticatorTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isPreserveShareCase()configuration option to preserve share name case instead of converting to uppercaseSmbTreeConnectionto use case-insensitive matchingChanges
isPreserveShareCase()methodpreserveShareCasefield with defaultfalseisPreserveShareCase()to wrapped configjcifs.smb.client.preserveShareCasepropertyequalsIgnoreCase()for share comparison (2 locations)Usage
Test plan
isPreserveShareCase()in all configuration classesSmbTreeConnectionSmbTreeImpl🤖 Generated with Claude Code