fix(coderd): support string type for oidc response's expires_in json property #20152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depending on Azure AD product/version the property cannot be of type integer or string.
|
Hi @yyefimov, Thanks for your PR, and sorry for the delayed response. We usually review PRs once they start passing CI. Looks like there are some issues with formatting. Can you run |
Hello, this is done. thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of Azure AD return expires_in property as string. Use json.Number to accept either integer or string and then convert to int64.
Helpful links:
https://learn.microsoft.com/en-us/answers/questions/2337020/azure-ad-token-endpoint-returns-expires-in-as-stri
https://feedback.azure.com/d365community/idea/7772fd95-26e6-ec11-a81b-0022484ee92d