Fix GTK drag & drop and xprop #53
Conversation
If WM_STATE is not set both break
c9e0bff to
8278755
Compare
6850e60 to
f8f98cf
Compare
|
That is so cool, thank you for figuring this out so much! Tried it and it seems to fix the issue with firefox and a couple gtk apps. |
|
Wait, revisiting this: For some reason this seems to work perfectly for me in Xephyr, but break when I run it in as my actual WM. The same is true even post-#59. Have you tested this running worm as your actual system WM @codic12? If you don't have a similar experience it's entirely possible it's a peculiarity of my system somehow that I'll have to hunt down since NixOS can be weird like that sometimes. |
|
I was trying it on Xephyr when I tested, however right now at least between firefox and thunar it seems to be working fine (on the regular X server, not Xephyr) Some random old image to test: It would be so weird to have it be a nixos-specific issue though; I can't think of what might cause that. Perhaps NixOS ships a different X server, or it has some other oddities in this way? What applications did you try it with? |
|
I'm truly lost now -- it seems to be working again. I am testing a minor change currently, let me revert it and get back to you. |
|
Nope, still working. Maybe I was still running a pre-fix version by accident somehow. |
|
Oh well, at least it's working now 🤷 |
Closes #52.
Turns out that the section I found in i3's source code when first diagnosing the issue was exactly what I needed.
Also, it turns out xprop was also broken by WM_STATE not being set! Go figure.
It's not exactly as clean as the rest of your XChangeProperty calls since WM_STATE was neither in netAtoms or ipcAtoms, but I wasn't sure where I should put a new atom so I just interned it inline.