Reviewing files that changed from the base of the PR and between a3d622b and 6ba776f.

• components/unit-cards/battlegroup-card.tsx (1 hunks)
• src/unitStats/battlegroup.ts (2 hunks)
• src/unitStats/mappingBattlegroups.ts (3 hunks)

• GitHub Check: Build and run prettier
• GitHub Check: Deploy Web Preview

src/unitStats/battlegroup.ts (2)

57-57: LGTM: Clean type extension.

The name field is properly typed and documented, following the existing code style.

---

135-135: LGTM: Field properly populated.

The name is correctly passed through from the raw battlegroup data.

src/unitStats/mappingBattlegroups.ts (3)

13-13: LGTM: Type field added correctly.

The name field follows the existing type structure and is properly documented.

---

39-39: LGTM: Initialization follows existing pattern.

The empty string default is consistent with other field initializations in the same object.

---

63-63: I'll help you verify the concerns raised in this review comment. Let me start by examining the relevant code to understand the context and potential issues.
<function_calls>

#!/bin/bash

First, let's understand the structure and find the files mentioned

echo "=== Finding relevant files ==="
find . -type f -name "mappingBattlegroups.ts" 2>/dev/null | head -20
find . -type f -name "battlegroup-card.tsx" 2>/dev/null | head -20


</function_calls>
<function_calls>

#!/bin/bash

Read the mappingBattlegroups.ts file to see context around line 63

echo "=== Examining mappingBattlegroups.ts ==="
cat -n src/unitStats/mappingBattlegroups.ts | sed -n '1,80p'


</function_calls>
<function_calls>

#!/bin/bash

Find and read the battlegroup-card.tsx file, especially around line 94

echo "=== Finding battlegroup-card.tsx ==="
find . -type f -name "battlegroup-card.tsx" 2>/dev/null

echo "=== Examining battlegroup-card.tsx ==="
if [ -f "src/components/battlegroup-card.tsx" ]; then
cat -n src/components/battlegroup-card.tsx | sed -n '80,110p'
fi


</function_calls>
<function_calls>

#!/bin/bash

Let's search for where resolveLocstring is defined and what it does

echo "=== Finding resolveLocstring definition ==="
rg -n "resolveLocstring" --type=ts --type=tsx -B2 -A5 | head -50


</function_calls>
<function_calls>

#!/bin/bash

Search for uiParent usage and screenName to understand previous behavior

echo "=== Searching for uiParent and screenName usage ==="
rg -n "uiParent" --type=ts --type=tsx -C3 | head -80

echo ""
echo "=== Searching for screenName usage ==="
rg -n "screenName" --type=ts --type=tsx -C2 | head -80


</function_calls>

components/unit-cards/battlegroup-card.tsx (2)

86-86: LGTM: Clean destructuring.

The name field is properly extracted from the resolved battlegroup data.

---

98-100: All new desc fields are correctly typed and match UnitUpgradeCard expectations.

The three new fields (brief_text, icon_name, brief_text_formatter) are all part of the UnitUpgradeDescription type (defined in unit-upgrade-card.tsx lines 24-39):

• brief_text: string | null — correctly assigned uiParent.briefText
• icon_name: string — correctly assigned uiParent.iconName
• brief_text_formatter: string — correctly set to empty string ""

The desc object includes all required fields and matches the pattern used in UnitUpgradeCard (lines 168-176) and ConstructableCard (lines 190-197) in the same file. No type mismatches or missing fields.