PLEDGE: Move to metadata, add getdents, initial ENOENT support #4232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved to metadata flags, got rid of stat too - Added getdents64 to tracing and it is also wrapped in the enforcer - Moved rel2abspath to list_util - Updated the tracing and enforcing to be logically consistent, for example, open is now metadata
Contributor
|
Looks good to me |
btovar
approved these changes
Sep 10, 2025
btovar
pushed a commit
that referenced
this pull request
Sep 25, 2025
- Moved to metadata flags, got rid of stat too - Added getdents64 to tracing and it is also wrapped in the enforcer - Moved rel2abspath to list_util - Updated the tracing and enforcing to be logically consistent, for example, open is now metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.