Fix busybox_jail_path file permissions #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the `fs::set_permissions(&busybox_jail_path, fs::Permissions::from_mode(755))?;` line so it sets proper permissions as it seems the 755 (decimal) was intended to be 0o755 (octal).
The difference in between the two can be seen below:
```
In [16]: !ls -la x
--wxrw--wt 1 dc staff 0 Aug 23 19:52 x
In [17]: os.chmod('x', 0o755)
In [18]: !ls -la x
-rwxr-xr-x 1 dc staff 0 Aug 23 19:52 x
```
FWIW clippy should also be able to detect this.
Found thx to https://grep.app/search?q=from_mode%5C%28%5B0-9%5D%7B3%7D®exp=true
Owner
|
thanks! |
coord-e
added a commit
that referenced
this pull request
Mar 5, 2022
Bug fixes and dependency updates. Changelog for v1.3.0: - Fix busybox_jail_path file permissions ([#6](#6)) - Update and renew dependencies ([#7](#7)) - Fix usage of ExitStatus::from_raw and remove Error::DynamicSignaled ([#9](#9)) - Several CI fixes ([#8](#8), [#10](#10)) - This changed how `busybox` installed in the container images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
fs::set_permissions(&busybox_jail_path, fs::Permissions::from_mode(755))?;line so it sets proper permissions as it seems the 755 (decimal) was intended to be 0o755 (octal).The difference in between the two can be seen below:
FWIW clippy should also be able to detect this.
Found thx to https://grep.app/search?q=from_mode%5C%28%5B0-9%5D%7B3%7D®exp=true