Support of RFC8908 #603
Merged
Support of RFC8908 #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sevan : Any news on this PR? |
Member
|
"This branch cannot be rebased due to conflicts", will take a look this week and cut the release. |
Contributor
Author
|
Hi @sevan, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The continuation of the implementation of RFC8910 (#595).
RFC 8908 describes the API response called via DHCP option 114.
Coova is now able to respond directly to enable Captive Portal Identification if the
captiveportalapi_urioption is set to a URL likehttps://<coova_domain>:<uamuiport>/captive-portal-identification.From what I've seen with Android 16, to work, the URL must be HTTPS with a valid certificate.
RFCs 8910 and 8908 appear to support this as of Android 11 and iOS 14. Windows does not appear to implement it.
Devices that do not implement this RFC continue to work with the Captive Portal Detection method (capture via HTTP 302).
On Android (not tested with iOS), the
captiveportalvenue_info_urlparameter allows you to have a notification after authentication to open a web page. This URL must be accessible via HTTPS.Signed-off-by: Guillaume Marsay [email protected]