Observation manager needs to check if image_id exists before query operations#2704
Merged
ahojnnes merged 3 commits intocolmap:mainfrom Aug 13, 2024
Merged
Conversation
Contributor
|
This makes sense. Thank you. |
ahojnnes
approved these changes
Aug 13, 2024
Member
|
Good catch, thanks a lot. This should solve #2670. |
|
Hello, I am still encountering this problem with the latest code. Do you have any ideas |
Member
|
@liushuo1201 did you try the code at HEAD? if so, could you share some data such that we can reproduce it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This potential bug was discovered when I tried to use
colmap point_triangulatorcommand to perform 3d reconstruction with known camera poses, following this guideI think the issue is the following:
The error message I had is:
Through debugging the issue is pinned at line 83
observation_manager.ccAdding a check fixed the problem I had.
Any thoughts?