Fix copying behaviors of Reconstruction regarding camera pointers#2841
Conversation
|
The same is true for copy assignment? |
Yes. This is added now. |
src/colmap/scene/reconstruction.cc
Outdated
|
|
||
| Reconstruction::Reconstruction() : max_point3D_id_(0) {} | ||
|
|
||
| Reconstruction::Reconstruction(const Reconstruction& recon) |
There was a problem hiding this comment.
Would it make sense to add a test for these two new methods and assert equality between the two objects (or their serialized states)?
There was a problem hiding this comment.
Sorry maybe I am missing something. The Reconstruction class in colmap does not naturally support serialization? Do we write a new method for this?
There was a problem hiding this comment.
You can read and write the reconstruction using reconstruction_io?
There was a problem hiding this comment.
Thanks. This has been added. Wrote a new function for comparing binary files. I hope I did not miss any existing utilities in the codebase. PTAL
There was a problem hiding this comment.
I created a new PR that should hopefully simplify the tests in this PR: #2842
Previous copying behavior is very dangerous after the introduction of camera pointer.