Use the C++ string representation for Python dataclass objects#2855
Merged
Use the C++ string representation for Python dataclass objects#2855
Conversation
Contributor
|
Indeed. Thanks for the catch on the |
B1ueber2y
approved these changes
Oct 24, 2024
Contributor
B1ueber2y
left a comment
There was a problem hiding this comment.
The new type traits update works in my test.
ahojnnes
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2842 removed the custom
__repr__for some objects likeImage. Pycolmap then falls back to enumerating all the attributes, which is suboptimal - for example forImagewe don't want to print all 2D points to void bloating the console output. This PR recovers the previous behavior for objects for whichstringstream << objis defined.