Make target with all sources optional#2889
Merged
ahojnnes merged 6 commits intocolmap:mainfrom Nov 5, 2024
Merged
Conversation
ahojnnes
reviewed
Nov 5, 2024
e1e0cc6 to
a6ab0eb
Compare
ahojnnes
approved these changes
Nov 5, 2024
Contributor
ahojnnes
left a comment
There was a problem hiding this comment.
Thank you, this looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COLMAP_SRC_ROOT_FOLDERtarget since it's not compilable, missing linking target and would mess up static checks with vcpkg managed dependencies. relating to Why are there always 2 compile commands per target (most likely cmake related) #1093