Enable reading 16bit/channel (png) images to grayscale#2924
Merged
ahojnnes merged 3 commits intocolmap:mainfrom Nov 21, 2024
Merged
Enable reading 16bit/channel (png) images to grayscale#2924ahojnnes merged 3 commits intocolmap:mainfrom
ahojnnes merged 3 commits intocolmap:mainfrom
Conversation
Contributor
|
Thanks, this looks right to me. Ideally, we would construct a small unit test, where we use FreeImage to save a test image in 16bit and load it with our Bitmap class to check for expected pixel values. Is this something you would be able to implement? |
Contributor
Author
|
I added a test for this while trying to mimic the workflow used in other tests |
ahojnnes
approved these changes
Nov 20, 2024
Contributor
ahojnnes
left a comment
There was a problem hiding this comment.
Great, looks good to me. Thank you for adding a nice unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello ! I had some issues reading 16bit per channel pngs with the feature extractor. I tracked the issue to this line returning a null pointer.
Turns out FreeImage cant transform these images directly into grayscale as described here. This happens at line 104 in the FreeImage Conversion8.cpp file:
My solution is just transforming the image to 8bits per channel before transforming to grayscale.