Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix crashing CI #51

Merged
merged 14 commits into from
Mar 17, 2022
Merged

Fix crashing CI #51

merged 14 commits into from
Mar 17, 2022

Conversation

@sarlinpe
Copy link
Member

  • COLMAP recently switched to Metis: colmap/colmap@29a1e36
  • Running the CI on every branch creation is unnecessary

@sarlinpe sarlinpe enabled auto-merge (squash) March 16, 2022 13:57
@johnwlambert
Copy link
Contributor

Hi @skydes, thanks for the PR. It looks like the brew install of metis is appropriately installing the dependencies, but on linux, the metis library is not found. Is this what you're seeing? I suppose we may need to pass a flag like METIS_INCLUDE_DIRS?

@johnwlambert
Copy link
Contributor

I'm seeing:

Loaded plugins: fastestmirror, ovl
Loading mirror speeds from cached hostfile
 * base: mirrors.vcea.wsu.edu
 * centos-sclo-rh: repo1.sea.innoscale.net
 * epel: mirrors.kernel.org
 * extras: sjc.edge.kernel.org
 * updates: mirror.web-ster.com
No package build-essential available.
Error: Not tolerating missing names on install, stopping.
Loaded plugins: fastestmirror, ovl
Loading mirror speeds from cached hostfile
 * base: mirrors.vcea.wsu.edu
 * centos-sclo-rh: repo1.sea.innoscale.net
 * epel: mirrors.kernel.org
 * extras: sjc.edge.kernel.org
 * updates: mirror.web-ster.com

on the yum install, so yum isn't installing anything, perhaps

@sarlinpe
Copy link
Member Author

It seems that yum fails on most package installs, currently looking into this.

@sarlinpe sarlinpe disabled auto-merge March 16, 2022 15:51
@sarlinpe
Copy link
Member Author

@johnwlambert I cleaned up the yum installs. It previously failed to install suitesparse for Ceres.

@sarlinpe sarlinpe enabled auto-merge (squash) March 17, 2022 10:31
@sarlinpe sarlinpe requested a review from Phil26AT March 17, 2022 10:32
@sarlinpe sarlinpe disabled auto-merge March 17, 2022 10:32
@sarlinpe sarlinpe enabled auto-merge (squash) March 17, 2022 10:33
@sarlinpe sarlinpe merged commit 9dcc49c into master Mar 17, 2022
@sarlinpe sarlinpe deleted the paul/fix-CI branch March 17, 2022 10:40
@johnwlambert
Copy link
Contributor

Very nice work @skydes, thanks for cleaning that up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@johnwlambert johnwlambert Awaiting requested review from johnwlambert

@mihaidusmanu mihaidusmanu Awaiting requested review from mihaidusmanu

1 more reviewer

@Phil26AT Phil26AT Phil26AT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarlinpe @johnwlambert @Phil26AT