Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yfrommelt
Copy link

and update libs

Copy link
Member

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool! Thanks for opening the PR. I have one question about dist/index.js but otherwise this looks good to go. 👍


// Refresh list
colors.forEach(function(c) {
colors.ntc.forEach(function(c) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea what caused this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. When I run the demo I got an error because the plugin return a object of arrays just like the README said. I had to add the .ntc index to acces it.
Should the plugin return only one array if there is only one name passed ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey sorry for the delay. I am not able to look into this just yet, but I will put it on my list to review some time this week. Stay tuned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants