Feat/custom colour #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat/custom colour
fix: require not needed
alexgrigore1
approved these changes
Jan 5, 2021
|
It should probably be noted that this would allow overwriting the built-in lists in addition to adding new ones, just by using the same name (e.g. |
alexgrigore1
reviewed
Jan 5, 2021
There was a problem hiding this comment.
Actually, I just realized the library can accept a custom list of colors without any changes. It has the lists property exported. It is a simple object which can be extended with whatever list of colors you need. Here is an example:
import colorNamer from "color-namer";
colorNamer.lists.myCustomList = [
{ name: "myColor1", hex: "#F5F5DC" },
{ name: "myColor2", hex: "#FF00FF" },
...
];
const { myCustomList } = colorNamer("rgb(50,30,70)", { pick: ["myCustomList"] });
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for custom color lists (multiple)
This is an alternative to #8